UDSEntry compression ideas

[Mark]

On Sun, Sep 22, 2013 at 10:36 AM, David Faure <faure at kde.org> wrote:

> On Saturday 21 September 2013 15:45:55 Mark wrote:
> > The patch: http://paste.kde.org/p2ece1fd8/
> > Besides the line you said i also changed the line above. Hence asking
> for a
> > "OK" to commit.
>
> I said "Same for the other tests for d_type, they should all use == then."
> so we agree :-)
>

Done:
http://quickgit.kde.org/?p=kdelibs.git&a=commit&h=8b9f8b3082d43c4605ef78d18009b98b5997f7eb
Sorry for being extra careful.  Perhaps too careful..

>
> > Then a few questions for frameworks. How do i merge this change back in
> > frameworks?
>
> s/back/forward/ :)
> Don't.
> I regularly merge 4.11 to master and master to frameworks.
>

Awesome!

>
> > Note: i'm right now making a unittest for this specific case in
> frameworks,
> > not for 4.11. Just a general "udsentrytest" which should later be
> extended
> > to cover more of UDSEntry.
>
> OK, great. Although listing is rather part of jobtest or of your new
> listdirtest... This wasn't a UDSEntry bug, but a KIO::listDir bug (as far
> as
> the user of the API is concerned).
>

A gentle pointer to the K-F-D list where i posted this patch :)
If you could respond there?
It's title: "New test with C++11 and lambda (UDSEntry testcase)"

>
> --
> David Faure, faure at kde.org, http://www.davidfaure.fr
> Working on KDE, in particular KDE Frameworks 5
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130922/7b6e1c83/attachment.htm>