Review Request 112567: Move the tab-handling away from DolphinMainWindow (Patch-Series)

Emmanuel Pescosta emmanuelpescosta099 at gmail.com
Wed Sep 11 14:53:21 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112567/
-----------------------------------------------------------

(Updated Sept. 11, 2013, 1:53 p.m.)


Review request for Dolphin.


Changes
-------

Added a overview image

All changes are now available in the emmanuelp/tabhandling branch of kde-baseapps.
http://quickgit.kde.org/?p=kde-baseapps.git&a=shortlog&h=2943ac85ba139b2131295d3d7cb60ce22f15e79f


Description
-------

Move the tab-handling away from DolphinMainWindow (Patch-Series)
    
Removed all code in DolphinMainWindow which is related to tabbed browsing,
except of some functions/slots which are required for the current UI, like
openNewTab(), openInNewTab(), ...
    
The tab-handling will be implemented again in another patch.

Split View and Tabbed Browsing will not work anymore with this patch!


Diffs
-----

  dolphin/src/dolphinmainwindow.h 7da5801 
  dolphin/src/dolphinmainwindow.cpp 4128cdf 

Diff: http://git.reviewboard.kde.org/r/112567/diff/


Testing
-------

Split View and Tabbed Browsing doesn't work (is ok)

Everything else works fine for me (Only one view)


File Attachments (updated)
----------------

Overview
  http://git.reviewboard.kde.org/media/uploaded/files/2013/09/11/dolphin_tab_handling.svg


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130911/ffc00519/attachment.htm>


More information about the kfm-devel mailing list