Review Request 112632: Fix copying text from statusbar

Frank Reininghaus frank78ac at googlemail.com
Tue Sep 10 09:24:15 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112632/#review39699
-----------------------------------------------------------


Thanks for analyzing this problem and for the patch!

Another patch for this bug has been submitted some time ago already (I don't know why it hasn't been committed yet): https://git.reviewboard.kde.org/r/112355/

The idea is to remove the "Copy statusbar text" option completely, as already discussed in the bug report. I think that the entry might have been added some time ago when all error messages were still shown in the status bar, to make it easier to copy the error message (I am not quite sure though, I was not involved in this thing).

- Frank Reininghaus


On Sept. 10, 2013, 7:13 a.m., Ashwin Rajeev wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112632/
> -----------------------------------------------------------
> 
> (Updated Sept. 10, 2013, 7:13 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> m_text was cleared when statusbar is set to default text. So copying the default text returns empty string.
> 
> 
> This addresses bug 324171.
>     http://bugs.kde.org/show_bug.cgi?id=324171
> 
> 
> Diffs
> -----
> 
>   dolphin/src/statusbar/dolphinstatusbar.cpp bff9566 
> 
> Diff: http://git.reviewboard.kde.org/r/112632/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ashwin Rajeev
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130910/b89aed15/attachment.htm>


More information about the kfm-devel mailing list