Review Request 112589: Use the Nepomuk Query Builder widget to add syntax-highlighting in Dolphin search

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112589/#review39614
-----------------------------------------------------------


Thanks for the patch!

I would say that the code looks reasonable (I'm not really familiar with the search code though). I've added a few small comments inline.

Hm, my kde-devel user's Dolphin also uses filenamesearch at the moment, even if Nepomuk is enabled. It does work fine in the 4.11.1 packages provided by OpenSuse though. Strange. I think it's due to some misconfiguration or some obsolete files here - I should try to wipe all config and build files, then rebuild and see if that helps.

But maybe there are people with working Nepomuk search inside Dolphin who can test it sooner than I can.

BTW, is there a Bugzilla component for the new parser? Some users will report any issues with it as Dolphin bugs, and I'd like to know where to assign these reports to.


dolphin/src/search/dolphinsearchbox.cpp
<http://git.reviewboard.kde.org/r/112589/#comment29189>

    This can be removed if you make m_queryParser a QScopedPointer.



dolphin/src/search/dolphinsearchbox.cpp
<http://git.reviewboard.kde.org/r/112589/#comment29187>

    Wouldn't it make sense for your QueryBuilder to offer a convenience function clear()? Most other widgets where the user can enter text have such a function.



dolphin/src/search/dolphinsearchbox.cpp
<http://git.reviewboard.kde.org/r/112589/#comment29190>

    const



dolphin/src/search/dolphinsearchbox.cpp
<http://git.reviewboard.kde.org/r/112589/#comment29188>

    I'm wondering if this function could get a name that makes it more obvious what it is about. Maybe "updateSearchInputParsing" or something like that?
    
    In the places where this slot is called directly, "slotWhatGroupClicked" looks a bit weird ;-)


- Frank Reininghaus


On Sept. 8, 2013, 11:58 a.m., Denis Steckelmacher wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112589/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2013, 11:58 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> When Dolphin is compiled with Nepomuk support, this patch replaces the plain line edit in which the user enters a search query with the new auto-completed QueryBuilder widget.
> 
> The user interface of the widget is shown in http://steckdenis.be/static/images/dolphin-query-builder.png .
> 
> The QueryBuilder widget can be found in the "steckdenis-gsoc2013" branch of nepomuk-widgets. You will also need the "steckdenis-gsoc2013" branch of nepomuk-core. This patch is not yet ready for merging as we have to wait that my other branches get merged in nepomuk-core and nepomuk-widgets. Some small changes in the API of the QueryBuilder are still possible.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchbox.h f3cc535 
>   dolphin/src/search/dolphinsearchbox.cpp ef9c2bf 
> 
> Diff: http://git.reviewboard.kde.org/r/112589/diff/
> 
> 
> Testing
> -------
> 
> Compiling with the CMake variable WITH_NepomukWidgets set to ON is possible and the resulting Dolphin works as expected (the query builder widget is displayed and queries can be entered in it). When this variable is set to OFF, Dolphin still builds and runs correctly, except that there is no auto-completion available.
> 
> The only problem is that even without the patch (and Nepomuk enabled system-wide and at compile time), Dolphin does not seem to use Nepomuk queries. Every search operation is slow and there is a huge amount of disk activity. Nepomuk queries like "modified last week" work perfectly well in KRunner. This problem (likely due to a misconfiguration on my desktop as it is present in Dolphin master and Dolphin 4.11, with Nepomuk-Core master or 4.11) prevents me from testing that queries entered in the query builder actually work. Can somebody with a working dolphin test that ?
> 
> 
> Thanks,
> 
> Denis Steckelmacher
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130908/532b9744/attachment.htm>