Review Request 112562: Make KFileItemModel::expandedParentsCount() work without accessing the data hash for every item

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112562/#review39486
-----------------------------------------------------------

Ship it!


Tested and works fine for me, please ship it!

- Emmanuel Pescosta


On Sept. 6, 2013, 3:41 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112562/
> -----------------------------------------------------------
> 
> (Updated Sept. 6, 2013, 3:41 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> After https://git.reviewboard.kde.org/r/112253/, this is the second patch that removes the need for accessing the QHash that stores all data for every item, which might enable us to reduce the memory usage considerably.
> 
> The idea is that we no longer assume that the "expandedParentsCount" for each item will be stored in the QHash. It is only accessed for items which are expanded, and which are not top-level items (i.e., which have an expandedParentsCount > 1).
> 
> I've also added some unit tests to improve the coverage of the affected code and make sure that I don't introduce any obvious regressions.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 5917e68 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 37a3051 
>   dolphin/src/tests/kfileitemmodeltest.cpp e55e3eb 
> 
> Diff: http://git.reviewboard.kde.org/r/112562/diff/
> 
> 
> Testing
> -------
> 
> Unit tests pass, and I haven't seen any regressions so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130906/d0aaa910/attachment.htm>