Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

[Eugene Shalygin]

> On Sept. 4, 2013, 8:25 p.m., Eugene Shalygin wrote:
> > I'm thankfull to all of you for lloking into this! Now I do not know what to do with these changes. If there will bee no new kdelibs 4.x releases, how these changes can be released? Will it happen only with Frameworks 5?
> 
> Frank Reininghaus wrote:
>     To my knowledge, kde-workspace is the only part of the KDE SC that will not have a 4.12 release.
>     
>     About the "proper way" that Martin referred to: there was a discussion on the frameworks mailing list about KGlobalSettings some time ago. It starts here:
>     
>     http://comments.gmane.org/gmane.comp.kde.devel.frameworks/3976
>     
>     and ends here:
>     
>     http://mail.kde.org/pipermail/kde-frameworks-devel/2013-August/003966.html
>     
>     (I could not find a good way to link to a mail thread that spans multiple months, sorry).
>     
>     I'm not an expert for these things though, and I'm not quite sure if I understand what the "proper way" is and if it can already be applied to 4.12. If it's not possible to add that functionality to kdelibs 4.12, then we could add a Dolphin-specific setting for the case sensitivity for the rest of the 4.x era. In that case, the feature would not be available in the file dialog though (even now it's a bit weird that the file dialog picks up the "natural sorting" setting that has been configured in Dolphin and offers no way to change it, but that's another topic).

After reading the thread I have the impression that naturalSorting will also gone. Then what to do? Replace calls to KGlobalSettings in Dolphin with calls to KConfig? From that discussion I did not understand what is the "proper way" for frameworks also.  

It is sad that these settings will not be present in 5.0 (at least in 5.0). I'm now very happy that all KDirSortFilterProxyModel are sorted in a way that I like. It would be nice to put these settings into locale settings (and KCM), but seems like KLocale is removed also :(


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112328/#review39376
-----------------------------------------------------------


On Aug. 29, 2013, 3:11 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112328/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 3:11 p.m.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Description
> -------
> 
> There are number of people who want to have case sensitive sorting in file manager and file dialogs (that would be consistent with locale settings).
> 
> The proposed patch adds a property to KGlobalSettings (caseSensitiveSorting()) and the new signal sortingModeChanged(), which deprecates naturalSortingChanged(), so the clients can connect to only one event and do not resort their models twice (maybe and option for the event to pass the change reason would be useful?).
> 
> KDirSortFilterProxyModel is changed in a trivial manner to use new event and handle case sensitivity changes.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=148550.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.h 96da20e 
>   kdeui/kernel/kglobalsettings.cpp 2e3a7eb 
>   kfile/kdirsortfilterproxymodel.h 63cf04c 
>   kfile/kdirsortfilterproxymodel.cpp 34ddcd2 
> 
> Diff: http://git.reviewboard.kde.org/r/112328/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130906/cc4858bc/attachment.htm>