Review Request 112541: Change the font-color of DolphinSearchBox when it gets (de)activated

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112541/#review39422
-----------------------------------------------------------


Thanks for the patch. My knowledge about colors (and guidelines how to use them) is extremely limited - feedback from people who know better about these things would be appreciated.

One thing that comes to my mind despite my lack of knowledge is that the Filename/Content/etc. buttons in the inactive search box now look to me like they are disabled (i.e., not clickable), even though that is not the case.

Moreover, if your proposal makes sense, should the header in Details View, the Filter Bar and other things not be drawn in the "inactive" font color as well if the view is inactive? Are there examples for such a behavior in other KDE apps?

- Frank Reininghaus


On Sept. 5, 2013, 2:59 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112541/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 2:59 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Follow-Up to commit 576481d114bdd0b7d1b4039612c7993f4cbb9b84
>     
> Change the font-color of DolphinSearchBox when it gets (de)activated, so
> that the user has a visual feedback in the search box too (and not only
> in the view).
> 
> 
> This addresses bug 296970.
>     http://bugs.kde.org/show_bug.cgi?id=296970
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchbox.cpp ef9c2bf 
> 
> Diff: http://git.reviewboard.kde.org/r/112541/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130905/220ef557/attachment.htm>