Review Request 112535: Nothing special, just a little bit of code cleanup in KItemListViewLayouter::doLayout().
Frank Reininghaus
frank78ac at googlemail.com
Thu Sep 5 15:29:27 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112535/#review39416
-----------------------------------------------------------
Ship it!
Thanks, looks good! I like it when the same stuff gets done with less and more readable code :-)
- Frank Reininghaus
On Sept. 5, 2013, 1:16 p.m., Emmanuel Pescosta wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112535/
> -----------------------------------------------------------
>
> (Updated Sept. 5, 2013, 1:16 p.m.)
>
>
> Review request for Dolphin.
>
>
> Description
> -------
>
> Nothing special, just a little bit of code cleanup in KItemListViewLayouter::doLayout().
>
> Make use of QSizeF::transpose() and simplify the m_itemInfos usage.
>
>
> Diffs
> -----
>
> dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp da569b3
>
> Diff: http://git.reviewboard.kde.org/r/112535/diff/
>
>
> Testing
> -------
>
> Everything works fine.
>
>
> Thanks,
>
> Emmanuel Pescosta
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130905/f3c02ec9/attachment.htm>
More information about the kfm-devel
mailing list