Review Request 112534: Fix Bug 296970 - split view wrong behavior with search tab

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112534/#review39412
-----------------------------------------------------------

Ship it!


Cool, thanks for analyzing this bug! Patch looks good to me :-)

- Frank Reininghaus


On Sept. 5, 2013, 12:39 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112534/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2013, 12:39 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Implemented setActive(bool active), isActive() and activated() signal
> for DolphinSearchBox - similar to the KUrlNavigator implementation.
> 
> The search box sends the activated() signal when one of the child widgets
> gets the focus.
> 
> 
> This addresses bug 296970.
>     http://bugs.kde.org/show_bug.cgi?id=296970
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinviewcontainer.cpp 1e9e79a 
>   dolphin/src/search/dolphinsearchbox.h f3cc535 
>   dolphin/src/search/dolphinsearchbox.cpp ef9c2bf 
> 
> Diff: http://git.reviewboard.kde.org/r/112534/diff/
> 
> 
> Testing
> -------
> 
> Works for me.
> 
> 1. Enable Split View
> 2. Start search in one of the two views
> 3. Activate the other view and wait for search finished
> 4. Change the search text and notice that the active view is now the view with search enabled
> 5. Go back to the other view immediately after you have finished the search text change
> 6. Only the view with search enabled should show the search results
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130905/76d430b0/attachment.htm>