Review Request 112330: Add case sensitive sorting option to KFileItemModel and 'General settings'

[Eugene Shalygin]

> On Sept. 4, 2013, 4:44 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/settings/general/behaviorsettingspage.cpp, line 133
> > <http://git.reviewboard.kde.org/r/112330/diff/2/?file=185508#file185508line133>
> >
> >     So resortAllItems() will be called twice?
> >     
> >     Maybe we should use the resort-all-items-timer on settings change too, 
> >     because I think the 500 ms delay is meaningless in this case. 
> >     
> >     What do you think?

No, it will be called only once, since we do not connect to naturalSortingChanged() signal anymore. We use only the new signal (sortingModeChanged()).


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112330/#review39356
-----------------------------------------------------------


On Aug. 29, 2013, 3:12 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112330/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 3:12 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Depends on https://git.reviewboard.kde.org/r/112328/
> 
> The patch adds reading of KGlobalSettings::caseSensitiveSorting() in KFileItemModel and UI widget for changing it, identical to "natural sorting" widget.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=148550.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 304161a 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 69db217 
>   dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d 
> 
> Diff: http://git.reviewboard.kde.org/r/112330/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130904/3bf8b731/attachment.htm>