Review Request 112328: Add case sensitive sorting option to KGlobalSettings and KDirSortFilterProxyModel

[Eugene Shalygin]

> On Sept. 4, 2013, 3:35 p.m., Frank Reininghaus wrote:
> > kdeui/kernel/kglobalsettings.cpp, line 923
> > <http://git.reviewboard.kde.org/r/112328/diff/2/?file=185514#file185514line923>
> >
> >     Could you explain briefly why this reparseConfiguration() call is needed now, and it was not needed before? It's not obvious to me at first sight.

Suppose we have several running programs, that use these settings. Then we launch Dolphin or its "General" KCM and change sorting mode. We write changes to the configuration file and ask kdelibs in other applications to emit signals. And these other kdelibs instances have to reload the configuration file in order to supply new values to applications. Without this change I saw that other Dolphin instances were not applying changes when I was changing the settings in one instance. If the configuration file not reloaded, there is no sense to send events to other instances at all. 


- Eugene


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112328/#review39347
-----------------------------------------------------------


On Aug. 29, 2013, 3:11 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112328/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 3:11 p.m.)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Description
> -------
> 
> There are number of people who want to have case sensitive sorting in file manager and file dialogs (that would be consistent with locale settings).
> 
> The proposed patch adds a property to KGlobalSettings (caseSensitiveSorting()) and the new signal sortingModeChanged(), which deprecates naturalSortingChanged(), so the clients can connect to only one event and do not resort their models twice (maybe and option for the event to pass the change reason would be useful?).
> 
> KDirSortFilterProxyModel is changed in a trivial manner to use new event and handle case sensitivity changes.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=148550.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Diffs
> -----
> 
>   kdeui/kernel/kglobalsettings.h 96da20e 
>   kdeui/kernel/kglobalsettings.cpp 2e3a7eb 
>   kfile/kdirsortfilterproxymodel.h 63cf04c 
>   kfile/kdirsortfilterproxymodel.cpp 34ddcd2 
> 
> Diff: http://git.reviewboard.kde.org/r/112328/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130904/6644c336/attachment.htm>