Review Request 112330: Add case sensitive sorting option to KFileItemModel and 'General settings'

[Frank Reininghaus]

> On Sept. 2, 2013, 9:41 p.m., Frank Reininghaus wrote:
> > Thanks for the patch and sorry for the late reply! I was away for a couple of days, and I'm still fighting with the huge pile of mails in my inbox.
> > 
> > Looks good at first sight, but I'll have a closer look soon.

Looks good to me. Unless anyone else has suggestions how to improve the patch, this is OK to go into master (because it's in principle a new feature, and it needs new strings) from my point of view as soon as the necessary API has been added to kdelibs.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112330/#review39216
-----------------------------------------------------------


On Aug. 29, 2013, 1:12 p.m., Eugene Shalygin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112330/
> -----------------------------------------------------------
> 
> (Updated Aug. 29, 2013, 1:12 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Depends on https://git.reviewboard.kde.org/r/112328/
> 
> The patch adds reading of KGlobalSettings::caseSensitiveSorting() in KFileItemModel and UI widget for changing it, identical to "natural sorting" widget.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=148550.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=148550
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 304161a 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 69db217 
>   dolphin/src/settings/general/behaviorsettingspage.h 7a9c2f0 
>   dolphin/src/settings/general/behaviorsettingspage.cpp cbbde1d 
> 
> Diff: http://git.reviewboard.kde.org/r/112330/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> Thanks,
> 
> Eugene Shalygin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130904/75e2d2df/attachment.htm>