Review Request 112483: Fix color role in services list

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/112483/#review39297
-----------------------------------------------------------


This review has been submitted with commit 91a2e523f1bc2f29e9e988accdca4a68656ddbdc by Christoph Feck to branch KDE/4.11.

- Commit Hook


On Sept. 3, 2013, 2:16 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/112483/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2013, 2:16 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The service list uses Base background, so it requires Text color role. CheckBoxes use WindowText color role, because they are made for Window background.
> 
> Instead of "hacking" the palette, a better fix would be to not use CheckBox, but render the label separately. I tried that, but found issues with selection/focus rectangle, and settled for the hack. We use palette hacks at a few places in kdelibs, too.
> 
> Oh, forget to add:
> This does not change the text color for selected items, this would indeed require a separate label text.
> 
> 
> This addresses bug 286459.
>     http://bugs.kde.org/show_bug.cgi?id=286459
> 
> 
> Diffs
> -----
> 
>   dolphin/src/settings/serviceitemdelegate.cpp 4cd193a 
> 
> Diff: http://git.reviewboard.kde.org/r/112483/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130903/13711a1a/attachment.htm>