Review Request 113290: Fix for broken view state restoration (recent regression in KDE/4.11 branch)

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113290/#review42386
-----------------------------------------------------------


This review has been submitted with commit ec4efae6428a0d32657b6aaf0ceaef8238748f5c by Frank Reininghaus to branch KDE/4.11.

- Commit Hook


On Oct. 16, 2013, 8:36 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113290/
> -----------------------------------------------------------
> 
> (Updated Oct. 16, 2013, 8:36 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 326039
>     http://bugs.kde.org/show_bug.cgi?id=326039
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> The fix for bug 161385 (which was about Dolphin still showing an empty view if a device that had been unmounted earlier was clicked in the Places Panel) caused a regression: the view state (current item, scroll position, Details View expansion state) is not restored any more when going "Back".
> 
> The reason is that "m_view->reload()" in DolphinViewContainer::setUrl(const KUrl& newUrl) is now always executed just after entering a directory, and that command overwrites this information.
> 
> Distinguishing between "change URL" and "reload the view" works better if it's done in DolphinMainWindow instead of DolphinViewContainer.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.h 7da5801 
>   dolphin/src/dolphinmainwindow.cpp ccef356 
>   dolphin/src/dolphinviewcontainer.cpp c8fc757 
> 
> Diff: http://git.reviewboard.kde.org/r/113290/diff/
> 
> 
> Testing
> -------
> 
> Fixes the bug, and I verified that the new approach also fixes bug 161385.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131026/00509e6b/attachment.htm>