Review Request 113233: Two small simplifications in KItemListViewLayouter
Frank Reininghaus
frank78ac at googlemail.com
Wed Oct 16 22:03:45 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113233/
-----------------------------------------------------------
(Updated Oct. 16, 2013, 9:03 p.m.)
Status
------
This change has been marked as submitted.
Review request for Dolphin.
Repository: kde-baseapps
Description
-------
The first change is to remove the unneeded variable rowCount.
The second simplifies the calculation of the member m_maximumScrollOffset. If I'm not mistaken, we can just use the current value of "y" because this is the offset that the next row would have.
Diffs
-----
dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp d6e78ae
Diff: http://git.reviewboard.kde.org/r/113233/diff/
Testing
-------
Layout still looks the same to me in all view modes, and also with grouping enabled.
Thanks,
Frank Reininghaus
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131016/34da4a1a/attachment.htm>
More information about the kfm-devel
mailing list