Review Request 113234: Stop loading the current URL when pressing Esc

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113234/
-----------------------------------------------------------

(Updated Oct. 16, 2013, 9 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin and Kai Uwe Broulik.


Bugs: 323181
    http://bugs.kde.org/show_bug.cgi?id=323181


Repository: kde-baseapps


Description
-------

I think that Kai Uwe's idea to make Esc cancel loading the current folder makes sense.

It looks like the most straightforward way to implement this is to make KItemListController emit a new signal when pressing Esc, make DolphinView::stopLoading() a slot and connect the two.


Diffs
-----

  dolphin/src/kitemviews/kitemlistcontroller.h 4d5fee3 
  dolphin/src/kitemviews/kitemlistcontroller.cpp 9335ab8 
  dolphin/src/views/dolphinview.h 86bc5c1 
  dolphin/src/views/dolphinview.cpp c1d2453 

Diff: http://git.reviewboard.kde.org/r/113234/diff/


Testing
-------

Pressing Esc can be used to stop time-consuming this like, e.g., a search.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131016/ba372ab8/attachment.htm>