Review Request 113233: Two small simplifications in KItemListViewLayouter

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113233/#review41753
-----------------------------------------------------------

Ship it!


Looks good! Thanks

- Emmanuel Pescosta


On Oct. 13, 2013, 7:26 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113233/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2013, 7:26 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> The first change is to remove the unneeded variable rowCount.
> 
> The second simplifies the calculation of the member m_maximumScrollOffset. If I'm not mistaken, we can just use the current value of "y" because this is the offset that the next row would have.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/private/kitemlistviewlayouter.cpp d6e78ae 
> 
> Diff: http://git.reviewboard.kde.org/r/113233/diff/
> 
> 
> Testing
> -------
> 
> Layout still looks the same to me in all view modes, and also with grouping enabled.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131014/f14c5e14/attachment.htm>