Review Request 113191: Files passed as arguments: Ignore unsupported files and open archives as folders

[Erik Hahn]

> On Oct. 10, 2013, 12:18 p.m., Emmanuel Pescosta wrote:
> > dolphin/src/views/dolphinview.cpp, line 1240
> > <http://git.reviewboard.kde.org/r/113191/diff/2/?file=200251#file200251line1240>
> >
> >     These changes are not so good, because it can drastically cut down the performance in some situations - We use this function in other places too and sometimes for many items, whose mimetype is not always known. 
> >     
> >     So please call item.mimetype() before you call openItemAsFolder() and discard these changes.
> >     
> >     Thanks :)

Yes, I half expected that.

Shouldn't the delayedMimeType argument to KFileItem do the same thing? It doesn't but I have no idea what else its purpose could be.


- Erik


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113191/#review41492
-----------------------------------------------------------


On Oct. 10, 2013, 2:55 p.m., Erik Hahn wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113191/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2013, 2:55 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> With this patch, Dolphin ignores all files passed to it that it can't handle instead of opening them externally. I assume that it wasn't actually intended to be usable as a xdg-open replacement.
> 
> Also, archives are now opened inside Dolphin so it can be used as an archive manager at least for local files. If the user tries to open a remote archive Dolphin still opens it externally; I have observed that if it receives one as an argument, it will display a pseudo-folder that contains only said archive. So having it set as the archive handler is still broken, but in a less annoying way.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphinmainwindow.cpp 4128cdf 
> 
> Diff: http://git.reviewboard.kde.org/r/113191/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Erik Hahn
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131010/4a48f266/attachment.htm>