Review Request 113101: Fix Bug 287983 - Dolphin truncates tooltip information for long file names

[Luciano Montanaro]

I wish size calculations were done in font-relative units... using
QFontMetrics on the tooltip font. Then you could pick a reasonable size
that accounts for user preferences and pixel density.


On Thu, Oct 10, 2013 at 3:09 PM, Kai Uwe Broulik <kde at privat.broulik.de>wrote:

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113101/
>
> Can you test it doesn't break with huge font sizes? A fixed 250px maximum width looks dangerous to me.
>
>
> - Kai Uwe
>
> On October 4th, 2013, 5:53 p.m. UTC, Emmanuel Pescosta wrote:
>   Review request for Dolphin.
> By Emmanuel Pescosta.
>  *Bugs: * 287983 <http://bugs.kde.org/show_bug.cgi?id=287983>
>  *Repository: * kde-baseapps
> Description
>
> Use KStringHandler and QTextLayout to wrap the text (file name)
> into the maximum width of the label "name".
>
>   Testing
>
> Works
>
>   Diffs
>
>    - dolphin/src/views/tooltips/filemetadatatooltip.cpp (c22f6be)
>
> View Diff <http://git.reviewboard.kde.org/r/113101/diff/>
> File Attachments
>
>    - Tooltip Widget with a long file name - Dolphin 4.11.2<http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/b5e3213b-ca9b-4abc-b2b7-1f62f8748521__snapshot11.png>
>    - Tooltip Widget with a long file name - Dolphin 4.11.3 (Patched)<http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/26a7063d-ad96-4a8d-a0b2-fc0414ab1304__snapshot12.png>
>
>


-- 
Luciano Montanaro

Anyone who is capable of getting themselves made President should on no
account be allowed to do the job. -- Douglas Adams
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131010/0305e1fc/attachment.htm>