Review Request 113849: Lazy-load the item data also in Compact View

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113849/#review44884
-----------------------------------------------------------

Ship it!


Ship It!

- Emmanuel Pescosta


On Nov. 14, 2013, 9:30 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113849/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2013, 9:30 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> My recent changes that prevent that all data for each item are saved in a QHash already when loading the folder (see https://git.reviewboard.kde.org/r/112725/), which save both memory and time, do not work yet in Compact View, because KItemListWidgetInformant::itemSizeHint() calls the model's data(int) method for every item, which initializes the hash.
> 
> This patch prevents that by accessing the file name directly if only the "Name" is shown in the view, just like it's done in Icons View.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp 302150f 
> 
> Diff: http://git.reviewboard.kde.org/r/113849/diff/
> 
> 
> Testing
> -------
> 
> I could not find any regressions. Memory usage in Compact View is now comparable to Icons/Details.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131130/cd716d17/attachment.htm>