Review Request 113930: Make the "Create New..." menu in the "item context menu" work again

[Emmanuel Pescosta]

> On Nov. 21, 2013, 12:43 a.m., Commit Hook wrote:
> > This review has been submitted with commit 2736d24f98c2880713264250c42bc0309e86e8b9 by Frank Reininghaus to branch KDE/4.12.
> 
> Frank Reininghaus wrote:
>     I've pushed the patch to KDE/4.12 because it's quite a straightforward change that restores the old behavior (DolphinMainWindow is the parent of the menu), and I prefer to not ship this regression in further beta and RC releases :-)

Hmm too late for a ship it, but thanks for fixing this bug :)


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113930/#review44078
-----------------------------------------------------------


On Nov. 21, 2013, 12:43 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113930/
> -----------------------------------------------------------
> 
> (Updated Nov. 21, 2013, 12:43 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 327783
>     http://bugs.kde.org/show_bug.cgi?id=327783
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Since https://git.reviewboard.kde.org/r/111989/, the "Create New..." menu in the context menu that appears when right-clicking a folder is not a child of the DolphinMainWindow any more, but of the context menu itself. This seems to be the reason why the dialog that asks for a file name when choosing one of the "Create New..." options disappears immediately.
> 
> This patch makes sure that the main window is the parent of the "Create New..." menu again.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp 7d11c3b 
> 
> Diff: http://git.reviewboard.kde.org/r/113930/diff/
> 
> 
> Testing
> -------
> 
> Fixes the problem for me.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131121/632d6ed1/attachment.htm>