Review Request 113939: Update the geometries of the viewport and the scene of KItemListContainer with the size of the view since the scrollbar visibility may have changed.

[Yichao Yu]

> On Nov. 20, 2013, 6:52 p.m., Frank Reininghaus wrote:
> > Thanks for the debugging and the nice patch, I can confirm that it works nicely now, and I have pushed your patch to the KDE/4.11 branch.

Just one minor question, is beta3 tagged yet? (or in another word will this be included in beta?)


- Yichao


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113939/#review44082
-----------------------------------------------------------


On Nov. 20, 2013, 6:50 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113939/
> -----------------------------------------------------------
> 
> (Updated Nov. 20, 2013, 6:50 p.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus and Peter Penz.
> 
> 
> Bugs: 327709
>     http://bugs.kde.org/show_bug.cgi?id=327709
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> When resizing the window and when `KItemListContainer::updateGeometries` is called before the scrollbar visibility is updated, a relayout is triggered in `m_controller->view()->setGeometry` which updates the scrollbar visibility and calls back to `KItemListContainer::updateGeometries` again. Since the first call, which has the wrong geometry (due to the incorrect scrollbar states), updates the geometries of the scene and viewport after the second call (which has the right geometry!!) returns, the final result is a size corresponds to old scrollbar state.
> 
> This patch uses the new geometry of the view after updating it (since it might not be the size we put in) and therefore makes the sizes consistent.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp cd2fca1 
> 
> Diff: http://git.reviewboard.kde.org/r/113939/diff/
> 
> 
> Testing
> -------
> 
> Compiles, solves the problem here.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131121/63b11908/attachment.htm>