Review Request 113902: Fix scrollbar spacing when no scrollbar is visible in dolphin.

[Yichao Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113902/
-----------------------------------------------------------

(Updated Nov. 18, 2013, 2:02 p.m.)


Review request for Dolphin, Frank Reininghaus and Peter Penz.


Changes
-------

Add related bug


Bugs: 306631
    http://bugs.kde.org/show_bug.cgi?id=306631


Repository: kde-baseapps


Description
-------

Dolphin reserve space for scrollbar spacing even when no scrollbar is visible resulting in a ugly gap in the view when:
1. the theme uses QStyle::SH_ScrollView_FrameOnlyAroundContents and
2. the theme has a positive PM_ScrollView_ScrollBarSpacing.

QtCurve can have both while Oxygen have 1 but not 2.
To reproduce the problem with Oxygen style. Replace the `width += ....` (which returns -2 or 0 for Oxygen) with `width += 2`.

See more info here[1].

[1] https://github.com/QtCurve/qtcurve-qt4/issues/9#issuecomment-28630517


Diffs
-----

  dolphin/src/kitemviews/kitemlistcontainer.cpp f2e94b7 

Diff: http://git.reviewboard.kde.org/r/113902/diff/


Testing
-------

Logic looks right.
Compiled and it fixes the problem.


Thanks,

Yichao Yu

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131118/f981468c/attachment.htm>