Review Request 113902: Fix scrollbar spacing when no scrollbar is visible in dolphin.

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113902/#review43844
-----------------------------------------------------------

Ship it!


Thanks for the patch! I cannot test it at the moment, but only taking the scrollbar spacing into account if a scroll bar is shown looks very reasonable.

Concerning the branches: KDE/4.11 is sufficient for bug fixes. We merge KDE/4.11 into KDE/4.12 and KDE/4.12 into master regularly.

Do you have a KDE git account?

- Frank Reininghaus


On Nov. 16, 2013, 5:39 p.m., Yichao Yu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113902/
> -----------------------------------------------------------
> 
> (Updated Nov. 16, 2013, 5:39 p.m.)
> 
> 
> Review request for Dolphin, Frank Reininghaus and Peter Penz.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Dolphin reserve space for scrollbar spacing even when no scrollbar is visible resulting in a ugly gap in the view when:
> 1. the theme uses QStyle::SH_ScrollView_FrameOnlyAroundContents and
> 2. the theme has a positive PM_ScrollView_ScrollBarSpacing.
> 
> QtCurve can have both while Oxygen have 1 but not 2.
> To reproduce the problem with Oxygen style. Replace the `width += ....` (which returns -2 or 0 for Oxygen) with `width += 2`.
> 
> See more info here[1].
> 
> [1] https://github.com/QtCurve/qtcurve-qt4/issues/9#issuecomment-28630517
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp f2e94b7 
> 
> Diff: http://git.reviewboard.kde.org/r/113902/diff/
> 
> 
> Testing
> -------
> 
> Logic looks right.
> Compiled and it fixes the problem.
> 
> 
> Thanks,
> 
> Yichao Yu
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131117/e9c4dd16/attachment.htm>