Review Request 113101: Fix Bug 287983 - Dolphin truncates tooltip information for long file names

[Kai Uwe Broulik]

> On Oct. 16, 2013, 9:16 p.m., Frank Reininghaus wrote:
> > I think that it looks good now, thanks!
> > 
> > Kai (or anyone else with good font rendering knowledge), is there anything else that needs to be taken into account?

m_name->setMaximumWidth(fontMetrics.averageCharWidth() * 40);
looks fine to me. Thanks!


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113101/#review41841
-----------------------------------------------------------


On Nov. 1, 2013, 11:15 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113101/
> -----------------------------------------------------------
> 
> (Updated Nov. 1, 2013, 11:15 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Bugs: 287983
>     http://bugs.kde.org/show_bug.cgi?id=287983
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> Use KStringHandler and QTextLayout to wrap the text (file name)
> into the maximum width of the label "name".
> 
> 
> Diffs
> -----
> 
>   dolphin/src/views/tooltips/filemetadatatooltip.cpp c22f6be 
> 
> Diff: http://git.reviewboard.kde.org/r/113101/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> File Attachments
> ----------------
> 
> Tooltip Widget with a long file name - Dolphin 4.11.2
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/b5e3213b-ca9b-4abc-b2b7-1f62f8748521__snapshot11.png
> Tooltip Widget with a long file name - Dolphin 4.11.3 (Patched)
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/04/26a7063d-ad96-4a8d-a0b2-fc0414ab1304__snapshot12.png
> Patched version + normal font size
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/1ba52037-d951-48eb-8e39-862d88ffc85e__snapshot13.png
> Patched version + big font size
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/7b984cc1-274b-4982-8712-7638e3c0b72c__snapshot14.png
> 200dpi
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/10/15/6560bcd6-4475-4af0-97b5-76c9682f1368__snapshot15.png
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20131102/f9dda1c7/attachment.htm>