Review Request 110487: Bug 196035 - middle clicking on archive files in dolphin does not open them in a new tab

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110487/#review33301
-----------------------------------------------------------



dolphin/src/views/dolphinview.h
<http://git.reviewboard.kde.org/r/110487/#comment24634>

    @Frank:
    If you wonder why I have added the "bool browseThroughArchives" with the default value "true" - We need this, because we have to call this function anyway in "DolphinViewContainer::slotItemActivated" to handle the Desktop files properly. 
    
    But the only place we take care of the browse through archives settings is in "DolphinViewContainer::slotItemActivated", all other places allow browse through archives by default.


- Emmanuel Pescosta


On May 28, 2013, 3:33 p.m., Emmanuel Pescosta wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110487/
> -----------------------------------------------------------
> 
> (Updated May 28, 2013, 3:33 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> When 'browse through archives' is enabled, open archive files
> like folders on middle clicking, context menu -> new tab action
> and context menu -> new window action.
> 
> 
> This addresses bug 196035.
>     http://bugs.kde.org/show_bug.cgi?id=196035
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.cpp cddcc89 
>   dolphin/src/dolphinmainwindow.cpp 3b169a5 
>   dolphin/src/dolphinviewcontainer.cpp 44d4ee3 
>   dolphin/src/views/dolphinview.h e50dffc 
>   dolphin/src/views/dolphinview.cpp abf572f 
> 
> Diff: http://git.reviewboard.kde.org/r/110487/diff/
> 
> 
> Testing
> -------
> 
> Middle clicking or context menu -> new tab action opens the archive in a new tab, if 'browse through archives' is active.
> 
> Context menu -> new window action opens the archive in a new window, if 'browse through archives' is active.
> 
> Works for me.
> 
> 
> Thanks,
> 
> Emmanuel Pescosta
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130528/b58f372a/attachment.htm>