Review Request 110505: set KItemListView m_styleOption.palette from scenes first view

Commit Hook null at kde.org
Sat May 25 13:33:14 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110505/
-----------------------------------------------------------

(Updated May 25, 2013, 12:33 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

The palette is currently always constructed empty, thus defaults to the application general palette what fails if the view gets a different palette.
This is not "perfect" as it will not catch palette updates at runtime, but "works for me" (inverting docks at style polishment)

If QGraphicsWidget::palette() was used it would probably be possible to update the palette (via QGraphicsWidget::scene())


Diffs
-----

  dolphin/src/kitemviews/kitemlistview.h 6d609a9 
  dolphin/src/kitemviews/kitemlistview.cpp d009655 

Diff: http://git.reviewboard.kde.org/r/110505/diff/


Testing
-------

yes, getting readable text instead black-on-black


File Attachments
----------------

PoC
  http://git.reviewboard.kde.org/media/uploaded/files/2013/05/22/__proof.diff


Thanks,

Thomas Lübking

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130525/cec94bc2/attachment.htm>


More information about the kfm-devel mailing list