Review Request 110505: set KItemListView m_styleOption.palette from scenes first view

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110505/#review33038
-----------------------------------------------------------

Ship it!


All right, thanks for the detailed explanation! I agree that this makes sense then.

I have two small comments concerning the code, see below. Thanks for your work!


dolphin/src/kitemviews/kitemlistview.h
<http://git.reviewboard.kde.org/r/110505/#comment24437>

    I'd add the 'virtual' keyword here to make it clear at first sight that this overrides the function inherited from the base class (consistent with other Dolphin code).



dolphin/src/kitemviews/kitemlistview.cpp
<http://git.reviewboard.kde.org/r/110505/#comment24438>

    I think !scene()->views().isEmpty() is slightly clearer, but maybe that's a matter of taste.


- Frank Reininghaus


On May 22, 2013, 9:46 p.m., Thomas Lübking wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110505/
> -----------------------------------------------------------
> 
> (Updated May 22, 2013, 9:46 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> The palette is currently always constructed empty, thus defaults to the application general palette what fails if the view gets a different palette.
> This is not "perfect" as it will not catch palette updates at runtime, but "works for me" (inverting docks at style polishment)
> 
> If QGraphicsWidget::palette() was used it would probably be possible to update the palette (via QGraphicsWidget::scene())
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistview.h 6d609a9 
>   dolphin/src/kitemviews/kitemlistview.cpp d009655 
> 
> Diff: http://git.reviewboard.kde.org/r/110505/diff/
> 
> 
> Testing
> -------
> 
> yes, getting readable text instead black-on-black
> 
> 
> File Attachments
> ----------------
> 
> PoC
>   http://git.reviewboard.kde.org/media/uploaded/files/2013/05/22/__proof.diff
> 
> 
> Thanks,
> 
> Thomas Lübking
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130523/ee83dc65/attachment.htm>