Review Request 110401: Do not reset the 'isExpanded' state of folders when the 'refreshItems' signal is received.

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110401/#review32977
-----------------------------------------------------------


This review has been submitted with commit a79c3a391c278f58cd5ec69e56cfb3b6dec9ea17 by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On May 12, 2013, 7:53 a.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110401/
> -----------------------------------------------------------
> 
> (Updated May 12, 2013, 7:53 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> When the refreshItems signal is received for an item, we call KFileItemModel::retrieveData(), which updates many of the item's properties. Unfortunately, it also resets the 'isExpanded' state to false. The result is that folders are (partly) collapsed in the view when their contents change.
> 
> I propose to fix this by not initializing the 'isExpanded' role at all in retrieveData(). When KFileItemModel::isExpanded() tries to access the non-existing entry in the hash, the default-constructed QVariant evaluates to 'false' anyway.
> 
> 
> This addresses bug 299675.
>     http://bugs.kde.org/show_bug.cgi?id=299675
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 7ba78a4 
>   dolphin/src/tests/kfileitemmodeltest.cpp 58e83ac 
> 
> Diff: http://git.reviewboard.kde.org/r/110401/diff/
> 
> 
> Testing
> -------
> 
> Works for me, old and new unit tests pass.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130522/89867ca6/attachment.htm>