Review Request 110327: KMessageWidget: Remove decoration icon
Commit Hook
null at kde.org
Wed May 15 14:54:06 BST 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110327/#review32564
-----------------------------------------------------------
This review has been submitted with commit c8264896312e244e028be291dc390363d3aad843 by Aurélien Gâteau to branch master.
- Commit Hook
On May 15, 2013, 9:45 a.m., Aurélien Gâteau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110327/
> -----------------------------------------------------------
>
> (Updated May 15, 2013, 9:45 a.m.)
>
>
> Review request for Dolphin, Kate and kdelibs.
>
>
> Description
> -------
>
> This avoids confusion between the decoration icon and the close button, especially when type is KMessageWidget::Error. This happens for example with Dolphin when an error happens while trying to connect to an non available host.
> This change also has the nice side-effect of leaving more space for the widget text.
>
>
> Diffs
> -----
>
> kdeui/widgets/kmessagewidget.h 80a9980e0af63185e032ca759800bb9fb32b1557
> kdeui/widgets/kmessagewidget.cpp 724da0fa60a7b236d61685257e011fc49a30c1ff
>
> Diff: http://git.reviewboard.kde.org/r/110327/diff/
>
>
> Testing
> -------
>
> Tested with kmessagewidgetdemo, Dolphin and Kate.
>
>
> Thanks,
>
> Aurélien Gâteau
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130515/eb9fbdaf/attachment.htm>
More information about the kfm-devel
mailing list