Review Request 110347: PlacesModel: Do not allow files to be pinned

[Frank Reininghaus]

> On May 8, 2013, 10:36 a.m., Frank Reininghaus wrote:
> > Ship It!
> 
> Vishesh Handa wrote:
>     I just checked the code for KFilePlacesModel again (line 612), and it only allows directories. Should I change the patch to do the same?

Hm, I had thought that your check "QFileInfo(url.toLocalFile()).isFile()" is mostly equivalent to "!QFileInfo(url.toLocalFile()).isDir()", but maybe the latter is slightly clearer, so feel free to change it.


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110347/#review32249
-----------------------------------------------------------


On May 7, 2013, 10:49 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110347/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 10:49 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     PlacesModel: Do not allow files to be pinned
>     
>     It makes no sense
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 
> 
> Diff: http://git.reviewboard.kde.org/r/110347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130513/ebc074d7/attachment.htm>