Review Request 110348: PlacesPanel: Do not allow drop events into timeline or search folder

[Frank Reininghaus]

> On May 11, 2013, 4:34 p.m., Frank Reininghaus wrote:
> > Thanks for the patch! I'm fine with this suggestion (after considering Emmanuel's comments and adjusting the spaces in the 'if' statement to the kdelibs coding style).
> > 
> > I think we should not show an error message for this - IMHO, this is a bit too intrusive. From my point of view, the optimal solution would be to show the "drop forbidden" cursor when hovering one of these items, then we would not have this problem at all.
> > 
> > @Emmanuel: I'm not entirely sure what the best position for the message widget is, but as long as only serious errors (like those which prevent opening the URL, such that no files are shown at all) are shown in the KMessageWidget, the moving should not be a big issue, I think.
> 
> Vishesh Handa wrote:
>     Shall I push this patch then? I've fixed the issues raised by Emmanuel. 
>     
>     Or should I figure out how to show the drop forbidden cursor over the timeline and search folders?

>From my point of view it's OK to push this. We can look at the "drop forbidden cursor" option later (there are probably many more places where it makes sense to indicate that dropping is forbidden).


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110348/#review32355
-----------------------------------------------------------


On May 7, 2013, 10:50 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110348/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 10:50 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     PlacesPanel: Do not allow drop events into timeline or search folder
>     
>     They are read only. You cannot modify them, so it makes no point showing
>     the "Move/Copy Into" context menu.
>     
>     Maybe we should show an error?
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placespanel.cpp 0f5b83a 
> 
> Diff: http://git.reviewboard.kde.org/r/110348/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130513/eff9d05a/attachment.htm>