Review Request 110324: DolphinSearchBox setReadOnly: Update if either of the parameters change

[Frank Reininghaus]

> On May 12, 2013, 6:55 a.m., Frank Reininghaus wrote:
> > Thanks Vishesh for the patch! I would say that this looks reasonable, but I must admit that I'm not really familiar with most of the search-related code. Could you describe a use case in which the existing code causes a problem?

This is probably the fix for https://bugs.kde.org/show_bug.cgi?id=315796, right? In that case, please go ahead and ship it :-)


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110324/#review32369
-----------------------------------------------------------


On May 6, 2013, 1:57 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110324/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 1:57 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     DolphinSearchBox setReadOnly: Update if either of the parameters change
>     
>     This way when another read only query is added, the internal state is
>     changed and the search label gets updated.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/search/dolphinsearchbox.cpp 08d0433 
> 
> Diff: http://git.reviewboard.kde.org/r/110324/diff/
> 
> 
> Testing
> -------
> 
> works!
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130512/86abdc12/attachment.htm>