Review Request 109014: Don't show ellipsis on Rename action when inline renaming is enabled

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109014/
-----------------------------------------------------------

(Updated May 11, 2013, 10:11 p.m.)


Status
------

This change has been discarded.


Review request for Dolphin and Frank Reininghaus.


Description
-------

The ellipsis indicates to the user that when triggering the action a dialog that prompts further details (beyond a "are you sure?" confirmation) will appear. This is not the case when renaming inline.

Simple patch that uses a simple "Rename" in case inline renaming is enabled.


Diffs
-----

  dolphin/src/views/dolphinviewactionhandler.cpp c7832d7 

Diff: http://git.reviewboard.kde.org/r/109014/diff/


Testing
-------

Works as expected. Action is not updated when inline renaming settings change. I doubt it is worth the effort to make it do that.


Thanks,

Kai Uwe Broulik

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130511/8bc3ff33/attachment.htm>