Review Request 110347: PlacesModel: Do not allow files to be pinned

[Frank Reininghaus]

> On May 8, 2013, 5:42 a.m., Frank Reininghaus wrote:
> > Thanks for the patch! I agree with the general idea, but there are some files which actually do make sense to drop as a "Place", namely, .desktop files which point to a URL. So I'm afraid we'll need something more sophisticated than that.
> 
> Vishesh Handa wrote:
>     I was mostly just following the guidelines from the old places panel which did not allow files to be pinned.
>     
>     Also, does it really make sense to allow '.desktop' files in the panel? Say the '.desktop' file corresponds to an executable? Do we want the places panel to become a launcher of some kind?
>     
>     If you want I can update the patched and add a check to see if the filename ends with '.desktop'? But I think it's a bad idea.

I actually agree that it is not really necessary to provide the option to include .desktop links in the panel, but then there are always people who think that these are equivalent to symbolic links and should be treated as such (see, e.g., https://bugs.kde.org/show_bug.cgi?id=296608).

But if KFilePlaces* does not support drops of such things either (I didn't know that), then I think it's quite safe to make this change (after adding the braces as pointed out by Emmanuel - kdelibs coding style). But I'd still prefer to change this only in master.

Thanks for your work!


- Frank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110347/#review32237
-----------------------------------------------------------


On May 7, 2013, 10:49 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110347/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 10:49 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     PlacesModel: Do not allow files to be pinned
>     
>     It makes no sense
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 
> 
> Diff: http://git.reviewboard.kde.org/r/110347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130508/bec1e673/attachment.htm>