Review Request 110342: Dolphin Places: Make it easier to drag and drop items

[Vishesh Handa]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110342/
-----------------------------------------------------------

(Updated May 8, 2013, 8:24 a.m.)


Review request for Dolphin.


Changes
-------

Made sure the item is not longer being hovered when moving from drop -> between items.

This patch is so annoying! :)


Description
-------

    Dolphin Places: Make it easier to drag and drop items
    
    When doing a drop, a check is performed to see if it is within x pixels
    from the top or x pixel from the bottom of the rect. If it is, then the
    drop is considered a drop between items.
    
    This x was fixed to qMax( 4, myStyleOption.padding ) which would
    generally be 4. This is fine for some cases, but when the rectangle size
    increases then this 4 pixels is not enough. Hence this 'x' is now being
    set to 30% of the rectangle height.
    
    By default the rectangle height is 20 pixels, so x is now 6 instead of 4
    in the default case, which does make it slightly easier.
    
    Also, this in-between-items check is only performed when moving from one
    item to another. This is not good since if you enter the item and the
    bottom, the indicator is shown, and then as to start moving it up it
    stops showing, and then it should start showing again as you approach
    the top edge.
    
    Modified the code to run the check on every mouse drag event even if the
    hovered item has not changed.
    
    Both these changes combined make it much easier to drag and drop items.


Diffs (updated)
-----

  dolphin/src/kitemviews/kitemlistcontroller.cpp c6239df 
  dolphin/src/kitemviews/kitemlistview.cpp a2629c5 

Diff: http://git.reviewboard.kde.org/r/110342/diff/


Testing
-------

Much easier


Thanks,

Vishesh Handa

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130508/88651a11/attachment.htm>