Review Request 110347: PlacesModel: Do not allow files to be pinned

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110347/#review32237
-----------------------------------------------------------


Thanks for the patch! I agree with the general idea, but there are some files which actually do make sense to drop as a "Place", namely, .desktop files which point to a URL. So I'm afraid we'll need something more sophisticated than that.

- Frank Reininghaus


On May 7, 2013, 10:49 a.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110347/
> -----------------------------------------------------------
> 
> (Updated May 7, 2013, 10:49 a.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     PlacesModel: Do not allow files to be pinned
>     
>     It makes no sense
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 
> 
> Diff: http://git.reviewboard.kde.org/r/110347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130508/8adca9ff/attachment.htm>