Review Request 110326: Places Panel: Only show devices which do not exist in the Places

[Àlex Fiestas]

> On May 6, 2013, 7:19 p.m., Frank Reininghaus wrote:
> > Thanks for the patch, but I'm not entirely sure if this is a good idea. I agree that most people will only need one Places entry for each device, but in my experience, making guesses about what the user wants, and then taking actions based on these guesses without giving the user any choice, often leads to problems.
> > 
> > Moreover, I already see some problems with this implementation:
> > 
> > (a) Updates are needed: If the hand-made entry is removed, the device should be shown again.
> > (b) If the hand-made entry is hidden, the device should probably be shown again.
> > 
> > Implementing these things will make the code even more complex and possibly cause other issues.
> > 
> > On the other hand, the only price that we have to pay if this patch does not go in is that users who set up a hand-made "Place" for a device and don't want to see another entry for that in the "Devices" section have to hide it by hand. Or am I overlooking something?

I acknowledge that having duplicated entries is something we want to avoid, I'm unsure though if removing the places is what we want to do specially when the place has been manually created by the user.

A case that will always happen is Root, I find really stupid that we are still shipping with Root as a default Place, normal users do not care about what is beyond ~/ and right now we are showing that entry twice one for the root and one for the device.

Perhaps hiding the device makes more sense 


- Àlex


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110326/#review32152
-----------------------------------------------------------


On May 6, 2013, 3:22 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110326/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 3:22 p.m.)
> 
> 
> Review request for Dolphin, Àlex Fiestas and Frank Reininghaus.
> 
> 
> Description
> -------
> 
>     Places Panel: Only show devices which do not exist in the Places
>     
>     No point showing them twice.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 
> 
> Diff: http://git.reviewboard.kde.org/r/110326/diff/
> 
> 
> Testing
> -------
> 
> works!
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130507/81ae5678/attachment.htm>