Review Request 110323: Dolphin Places: React to Nepomuk system changes

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110323/#review32150
-----------------------------------------------------------

Ship it!


Thanks Vishesh, looks good (except for a few small style issues, see below). This change is very welcome - I did not know that Nepomuk provides such a convenient signal. I guess you can close https://bugs.kde.org/show_bug.cgi?id=304918 in your commit message.


dolphin/src/panels/places/placesitemmodel.cpp
<http://git.reviewboard.kde.org/r/110323/#comment23940>

    I would remove the first and the last spaces inside the connect() statement to be consistent with other code.



dolphin/src/panels/places/placesitemmodel.cpp
<http://git.reviewboard.kde.org/r/110323/#comment23941>

    There's no real need for a blank line immediately after the 'if'.



dolphin/src/panels/places/placesitemmodel.cpp
<http://git.reviewboard.kde.org/r/110323/#comment23942>

    Put a space behind the 'if', but remove those inside (...).


- Frank Reininghaus


On May 6, 2013, 5:06 p.m., Vishesh Handa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110323/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 5:06 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
>     Dolphin Places: React to Nepomuk system changes
>     
>     Reload the places panel when Nepomuk starts up and shutsdown. This way
>     the user does not need to restart Dolphin to see the custom searches and
>     places after Nepomuk switches on.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemmodel.h 34032bf 
>   dolphin/src/kitemviews/kstandarditemmodel.cpp dbf608c 
>   dolphin/src/panels/places/placesitemmodel.h e421878 
>   dolphin/src/panels/places/placesitemmodel.cpp 1acbb57 
> 
> Diff: http://git.reviewboard.kde.org/r/110323/diff/
> 
> 
> Testing
> -------
> 
> Works! The panel is updated as nepomuk is switched on and off. You can test it by running 'nepomukctl start' and 'nepomukctl stop'
> 
> 
> Thanks,
> 
> Vishesh Handa
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130506/d0a8678e/attachment.htm>