Review Request 109210: Do not skip rows in Details View when scrolling by clicking the empty area of the scroll bar

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109210/#review32110
-----------------------------------------------------------



dolphin/src/kitemviews/kitemlistview.cpp
<http://git.reviewboard.kde.org/r/109210/#comment23908>

    Wouldn't viewport()->height() be simpler?
    
    (it could replace the whole method, I would think)


- David Faure


On March 11, 2013, 5:26 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109210/
> -----------------------------------------------------------
> 
> (Updated March 11, 2013, 5:26 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Currently, the view is scrolled up or down by its height when the empty area of the scroll bar is clicked. However, this height includes the height of the header widget in Details View. Therefore, we skip a row when scrolling up or down.
> 
> I propose to not just use "view->size().height()" in KItemListController to determine the scroll bar's "pageStep", but to use a new member function of KItemListView which takes the possible header widget into account.
> 
> 
> This addresses bug 315619.
>     http://bugs.kde.org/show_bug.cgi?id=315619
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 
>   dolphin/src/kitemviews/kitemlistview.h 2baf20c 
>   dolphin/src/kitemviews/kitemlistview.cpp 6a68ae7 
> 
> Diff: http://git.reviewboard.kde.org/r/109210/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130505/3cd9b692/attachment.htm>