Review Request 110303: Reimplement handling of Shift while showing menu without KModifierKeyInfo

[Frank Reininghaus]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110303/#review32090
-----------------------------------------------------------

Ship it!


Thanks David for the patch! Looks good and works nicely here. But I'd still prefer that this is pushed to master only.

- Frank Reininghaus


On May 4, 2013, 6:39 p.m., David Faure wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110303/
> -----------------------------------------------------------
> 
> (Updated May 4, 2013, 6:39 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> Reimplement handling of Shift while showing menu without KModifierKeyInfo
> 
> Finding out whether shift is pressed initially can be done
> with qApp->keyboardModifiers(), and finding out that the user is pressing
> or release shift can be done with keyPressEvent/keyReleaseEvent.
> 
> This required to inherit from KMenu rather than having the KMenu
> as a member.
> 
> KModifierKeyInfo is only implemented on X11, so this makes the code
> more portable. If similar solutions can be found for other users of
> KModifierKeyInfo, it will be deprecated in KF5.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/dolphincontextmenu.h 3d0005d30a21810546dabd754ea166427ada5870 
>   dolphin/src/dolphincontextmenu.cpp bb26c7aaeda87ba77f9e241cfde6c4961ce90640 
>   dolphin/src/dolphinmainwindow.cpp 9454c8c42cb7f9df775773508ad4aec156f55f28 
> 
> Diff: http://git.reviewboard.kde.org/r/110303/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Faure
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130505/d6a869d2/attachment.htm>