Review Request 110164: Use the normal "HighlightedText" color for selected hidden items

Commit Hook null at kde.org
Thu May 2 18:30:14 BST 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/110164/#review31903
-----------------------------------------------------------


This review has been submitted with commit 572513a167cd9f9ffc022179c60a4b69a179d7f3 by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On April 24, 2013, 9:59 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/110164/
> -----------------------------------------------------------
> 
> (Updated April 24, 2013, 9:59 p.m.)
> 
> 
> Review request for Dolphin and Christoph Feck.
> 
> 
> Description
> -------
> 
> Since we use the regular "selected background" color for hidden items, I guess it makes sense to use the normal "selected text" color for these as well. Fixes the problem that the text is unreadable with some color schemes.
> 
> 
> This addresses bug 305734.
>     http://bugs.kde.org/show_bug.cgi?id=305734
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kstandarditemlistwidget.cpp d36265f 
> 
> Diff: http://git.reviewboard.kde.org/r/110164/diff/
> 
> 
> Testing
> -------
> 
> Works for me, no regressions seen so far.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130502/12482f4d/attachment.htm>


More information about the kfm-devel mailing list