Review Request 109622: Move "Bluetooth" entry from Places to Devices category
Àlex Fiestas
afiestas at kde.org
Thu Mar 21 10:00:59 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109622/#review29617
-----------------------------------------------------------
The change seems ok, but we should move it in all PlacesView, including the one in kdelibs for not creating more inconsistency.
- Àlex Fiestas
On March 20, 2013, 10:11 p.m., Kai Uwe Broulik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109622/
> -----------------------------------------------------------
>
> (Updated March 20, 2013, 10:11 p.m.)
>
>
> Review request for Dolphin, Àlex Fiestas and Frank Reininghaus.
>
>
> Description
> -------
>
> This patch moves the "Bluetooth" entry from Places to Devices category.
> Made sense to me that Bluetooth stuff is also under devices. Also makes Bluetooth devices (ie. you add your smartphone to the places list) appear there.
>
>
> This addresses bug 301276.
> http://bugs.kde.org/show_bug.cgi?id=301276
>
>
> Diffs
> -----
>
> dolphin/src/panels/places/placesitem.cpp 75e14d0
>
> Diff: http://git.reviewboard.kde.org/r/109622/diff/
>
>
> Testing
> -------
>
> Works as expected.
>
>
> Thanks,
>
> Kai Uwe Broulik
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130321/2e1d70df/attachment.htm>
More information about the kfm-devel
mailing list