Review Request 109614: Fix transition between normal and hover images
Aurélien Gâteau
agateau at kde.org
Wed Mar 20 16:44:30 GMT 2013
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109614/
-----------------------------------------------------------
Review request for Dolphin.
Description
-------
This is a follow-up to https://git.reviewboard.kde.org/r/108858/ . It has been brought to my attention the painting code I wrote was still wrong: when you mouse over items, the transition between the normal and hover images is not as smooth as it should be. Especially at the end, one has the feeling of a "bump".
I did quite a bit of debugging on that bug and wrote the result of my research in a huge comment. It may be too big, I am happy to remove it. I am probably going to blog about this anyway, since the hunt for that bug was interesting.
Diffs
-----
dolphin/src/kitemviews/kstandarditemlistwidget.cpp fcd0520457dc2cbe3ca1435129e20a0b9dfb28fc
Diff: http://git.reviewboard.kde.org/r/109614/diff/
Testing
-------
Moved the mouse over normal and hidden items, transition is smooth.
Thanks,
Aurélien Gâteau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130320/8115d527/attachment.htm>
More information about the kfm-devel
mailing list