Review Request 109471: Fix Bug 312014 - testing: group by file does not work correctly

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109471/
-----------------------------------------------------------

(Updated March 15, 2013, 2:53 p.m.)


Review request for Dolphin and Frank Reininghaus.


Changes
-------

Hello Frank, please test this patch ;) I have added a lot of new files, with different mimetypes, to my test folder -> Grouping by type works!

Changes:
Removed the determineMimeTypes and moved that stuff into retrieveData. Makes more sense, because sorting/grouping by type must know the mime-types of all files.

(This patch should also fix Bug 310705 and Bug 303873)


Description
-------

Fix wrong grouping of files (Esp. when sorting by file type)

Changes needed for master:
Add "const ItemData* parent = itemData->parent;" to retrieveData and remove the parent parameter from retrieveData.

Ideas for master:
Maybe use "void QtConcurrent::blockingMap ( Iterator begin, Iterator end, MapFunction function )" instead of a simple loop in setRoles, slotRefreshItems and createItemDataList.


This addresses bug 312014.
    http://bugs.kde.org/show_bug.cgi?id=312014


Diffs (updated)
-----

  dolphin/src/kitemviews/kfileitemmodel.h ef9dc98 
  dolphin/src/kitemviews/kfileitemmodel.cpp 7927245 

Diff: http://git.reviewboard.kde.org/r/109471/diff/


Testing
-------

Works for me.

Open a folder -> Sort by Type -> Sort by Rating -> Sort by .... -> Finally: Sort by Type (Files should be in the right file-type group)


Thanks,

Emmanuel Pescosta

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130315/ff7c0809/attachment.htm>