Review Request 109129: use plain text for information panel

[Luigi Toscano]

> On Feb. 26, 2013, 7:26 p.m., Frank Reininghaus wrote:
> > Thanks for taking care of this issue so quickly! From my point of view, this patch is good for the KDE/4.10 branch, but I guess that this is up to the translators to decide, so I sent a request to their mailing list. Let's wait and see what they say.
> 
> Frank Reininghaus wrote:
>     Considering that no translators objected so far, I guess that you can push it to KDE/4.10. Thanks!
> 
> Luigi Toscano wrote:
>     Please wait till tomorrow, or at least after that the tag of 4.10.1 has been created.
>     
>     If you commit it now, the new string won't be extracted today to gettext templates (scripty, our l10n script, is already running) and translators won't be able to translate it, so the string will be most probably untranslated in 4.10.1. 
>     Whenever a change affects translations, it should be done at least 25/26 hours before tagging (well, scripty runs in the CET night and the next morning, but just to be sure...).
> 
> Frank Reininghaus wrote:
>     Thanks Luigi for thinking of this important issue. I agree that it should better wait for 4.10.2 (i.e., commit after 4.10.1 tagging) then!
> 
> Xuetian Weng wrote:
>     shall I commit it now ?

The tag for 4.10.2 will be on March 28, so yes, please, commit it asap.


- Luigi


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109129/#review28169
-----------------------------------------------------------


On Feb. 24, 2013, 8:21 p.m., Xuetian Weng wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109129/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2013, 8:21 p.m.)
> 
> 
> Review request for Dolphin and Frank Reininghaus.
> 
> 
> Description
> -------
> 
> This is the real fix mentioned in https://git.reviewboard.kde.org/r/108584/ , in this way we can use "real" plain text.
> 
> First, use PlainText for label, then change the @info to @label to avoid KLocalizedString add html tag.
> 
> (Can this commit to 4.10?)
> 
> 
> This addresses bugs 262464 and 315693.
>     http://bugs.kde.org/show_bug.cgi?id=262464
>     http://bugs.kde.org/show_bug.cgi?id=315693
> 
> 
> Diffs
> -----
> 
>   dolphin/src/panels/information/informationpanelcontent.cpp 0c4c62f 
> 
> Diff: http://git.reviewboard.kde.org/r/109129/diff/
> 
> 
> Testing
> -------
> 
> &, &< &<>, AA<i>BB</i> now all ok.
> 
> 
> Thanks,
> 
> Xuetian Weng
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130313/1ea87df6/attachment.htm>