Review Request 109455: Follow-up to Emmanuel's restructurings in KFileItemModel

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109455/#review29100
-----------------------------------------------------------

Ship it!


Looks Great. Works Great. Passed all tests. Ship it! ;)

So we are "URL relation-ship parsing" free in KFileItemModel, thanks again for your help to achieve this :)

- Emmanuel Pescosta


On March 12, 2013, 5:26 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109455/
> -----------------------------------------------------------
> 
> (Updated March 12, 2013, 5:26 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Description
> -------
> 
> After https://git.reviewboard.kde.org/r/109180/, the main missing piece in the functionality around parent-child relationships that cannot be determined by parsing the URL is the removal or collapsing of expanded folders which have filtered children. This patch fixes it by removing the code that iterates over the filtered items from setExpanded() and slotItemsDeleted() to a new function removeFilteredChildren(), and making this function respect the parent-child relationships.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 1939671 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 61703e7 
>   dolphin/src/tests/kfileitemmodeltest.cpp cd2e8d7 
> 
> Diff: http://git.reviewboard.kde.org/r/109455/diff/
> 
> 
> Testing
> -------
> 
> Tried by browsing smb:, where collapsing a folder with filtered children did not work correctly before this commit. That works now; old and new tests pass.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130312/0c8eb59b/attachment.htm>