Review Request 109344: When sorting by "Type", determine the mime types as early as possible to make sure that icons can be loaded synchronously

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109344/#review29084
-----------------------------------------------------------


This review has been submitted with commit ba9e8d0a2d01cab3b709f6fd2778619a393f92de by Frank Reininghaus to branch master.

- Commit Hook


On March 7, 2013, 10:11 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109344/
> -----------------------------------------------------------
> 
> (Updated March 7, 2013, 10:11 p.m.)
> 
> 
> Review request for Dolphin and Christoph Feck.
> 
> 
> Description
> -------
> 
> Christoph reported in https://git.reviewboard.kde.org/r/109180/ (in a comment after the commit) that Dolphin feels slower after the commit. In particular, that icons are loaded asynchronously.
> 
> I thought about this issue and can indeed reproduce the problem when sorting by "Type". The problem is that after the commit, the ItemData are created earlier, at a point when the mime types are not known yet. I propose to move the synchronous mime type determination to createItemDataList to fix that.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodel.h 1939671 
>   dolphin/src/kitemviews/kfileitemmodel.cpp 688826e 
> 
> Diff: http://git.reviewboard.kde.org/r/109344/diff/
> 
> 
> Testing
> -------
> 
> Icons are loaded synchronously, and everything feels faster when sorting by "Type".
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130312/2144efe6/attachment.htm>