Review Request 109210: Do not skip rows in Details View when scrolling by clicking the empty area of the scroll bar

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109210/#review29007
-----------------------------------------------------------


This review has been submitted with commit 6ba70a6fbf64ac1d3534e9d9affdd9b399894087 by Frank Reininghaus to branch KDE/4.10.

- Commit Hook


On Feb. 28, 2013, 6:04 p.m., Frank Reininghaus wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109210/
> -----------------------------------------------------------
> 
> (Updated Feb. 28, 2013, 6:04 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Description
> -------
> 
> Currently, the view is scrolled up or down by its height when the empty area of the scroll bar is clicked. However, this height includes the height of the header widget in Details View. Therefore, we skip a row when scrolling up or down.
> 
> I propose to not just use "view->size().height()" in KItemListController to determine the scroll bar's "pageStep", but to use a new member function of KItemListView which takes the possible header widget into account.
> 
> 
> This addresses bug 315619.
>     http://bugs.kde.org/show_bug.cgi?id=315619
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kitemlistcontainer.cpp 5500851 
>   dolphin/src/kitemviews/kitemlistview.h 2baf20c 
>   dolphin/src/kitemviews/kitemlistview.cpp 6a68ae7 
> 
> Diff: http://git.reviewboard.kde.org/r/109210/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Frank Reininghaus
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130311/aa382aa8/attachment.htm>