Review Request 109343: Remove filtered items from the model if their parent folder is collapsed

Commit Hook null at kde.org
Sun Mar 10 17:27:09 GMT 2013


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109343/
-----------------------------------------------------------

(Updated March 10, 2013, 5:27 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Description
-------

Very similar to https://git.reviewboard.kde.org/r/108976/. Basically, the same problem that happens when deleting expanded folders with hidden children is also there when collapsing the expanded folder.

The fix is the same. I mostly copied the code from slotItemsDeleted() to setExpanded(), rather than factoring it out, to make merging into master easier.


This addresses bug 316335.
    http://bugs.kde.org/show_bug.cgi?id=316335


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodel.cpp d4c08a5 
  dolphin/src/tests/kfileitemmodeltest.cpp b76f4be 

Diff: http://git.reviewboard.kde.org/r/109343/diff/


Testing
-------

Works for me, old and new unit tests pass.


Thanks,

Frank Reininghaus

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20130310/b2c7ac3c/attachment.htm>


More information about the kfm-devel mailing list